Release 4.4.0 rc2#1764
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@jamesmisson is attempting to deploy a commit to the Universal Viewer Team on Vercel. A member of the Team first needs to authorize it. |
|
Tested it on a phone, and this is how it looks. Thanks @jamesmisson for all the work you have done here. |
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
I did some local testing, and this looks fine from my perspective too. I think we're ready to merge this, and possibly even to issue the release! Let me know if you need anything else from my end.
|
Thanks @LanieOkorodudu and @demiankatz for taking a look. We've got our prototype manifest for our item now but it's causing a bug in the release candidate. If you open up the manifest and navigate to a canvas with choice (e.g. f. 1r), the choice button doesn't appear: But it seems to appear if that canvas is specified in the URL: It also appears when you refresh the page. So I think this is to do with at which stage the button is being conditionally rendered. I'll take a look at this today then we'll need an rc3. |
jamesmisson
merged commit dcc44f6
into
UniversalViewer:release-4.4.0
|
I've fixed that bug here: jamesmisson#3 @demiankatz shall I merge this into my new rc-3 branch and create a PR for rc-3? |
Technically, it would be better to merge the fix directly into the release-4.4.0 branch first, and THEN create the RC3 branch -- ideally fixes should be applied before creating the RC tag; otherwise, when the release gets published, it won't include the fixes. |
|
Ah yes thanks @demiankatz . I've just done that: #1769 |
3 participants
Release candidate 2 fixes the bug in the download dialogue (see #1761) and adds mobile support for the choice menu (see jamesmisson#2)